[PATCH] D111875: [Support] [Windows] Manually clean up temp files on network shares

[Martin Storsjö via Phabricator via llvm-commits]

mstorsjo updated this revision to Diff 382448.
mstorsjo added a comment.

Changed `OF_Delete` to only set the delete access mode but not set the delete disposition. This simplifies the decision making, as `TempFile::Create` can just call `setDeleteDisposition` on its own and check the return value.

In theory, we could still consider using `RemoveFileOnSignal` for the case when manually removing the file at the end, but I think that'd complicate the code even further, so the files will be left behind on network drives on crashes.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D111875/new/

https://reviews.llvm.org/D111875

Files:
  llvm/include/llvm/Support/FileSystem.h
  llvm/lib/Support/Path.cpp
  llvm/lib/Support/Windows/Path.inc

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D111875.382448.patch
Type: text/x-patch
Size: 4536 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20211026/6d359ce2/attachment.bin>