[PATCH] D107934: [LowerTypeTests] Emit cfi_jt aliases regardless of function export

Peter Collingbourne via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Oct 26 12:53:13 PDT 2021


pcc added inline comments.


================
Comment at: llvm/test/LTO/X86/cfi_jt_aliases.ll:1
+; RUN: opt %s -o %t.bc
+; RUN: llvm-lto2 run -o %t.o %t.bc -save-temps \
----------------
Can this file and the ThinLTO one be combined into a single file?


================
Comment at: llvm/test/LTO/X86/cfi_jt_aliases.ll:16
+; CHECK-OD: a.cfi_jt>:
+; CHECK-OD: jmp {{.*}} <a.cfi_jt
+; CHECK-OD: b.cfi_jt>:
----------------
Shouldn't it be checking for a relocation pointing to `a`? (Same below.)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D107934/new/

https://reviews.llvm.org/D107934



More information about the llvm-commits mailing list