[PATCH] D112562: [SLP]Fix logical and/or reductions.

[Simon Pilgrim via Phabricator via llvm-commits]

RKSimon added a comment.

@spatel Any comments?



================
Comment at: llvm/lib/Transforms/Vectorize/SLPVectorizer.cpp:8019
+        return Builder.CreateSelect(LHS, Builder.getTrue(), RHS, Name);
+      LLVM_FALLTHROUGH;
     case RecurKind::And:
----------------
I'm not sure if I like the double fallthrough tbh, and I'd expect static analyzers to warn about the repeated if() - are adding extra 'return Builder.CreateBinOp' that bad?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D112562/new/

https://reviews.llvm.org/D112562