[PATCH] D112063: [lld][ELF] Add first bits to support relocation relaxations for AArch64

[Peter Smith via Phabricator via llvm-commits]

peter.smith added a comment.

Thanks for the update. One small optimisation suggestion. Otherwise looks good to me, and describes what was written in the ABI discussion. Assuming it can build and run something like the LLVM testsuite with -fpie, then I don't have any more comments. Happy to let MaskRay comment/approve, I may not be around for a few days.



================
Comment at: lld/ELF/Arch/AArch64.cpp:642
+    return false;
+  // Check the value of the sf bit.
+  if (!(ldrInstr >> 31))
----------------
I think this can be combined into the ldrInstr check. Please ignore if I've got my bit manipulation wrong.
```
 // Check if the second instruction is a 64-bit LDR.
 if ((ldrInstr & 0xBB000000) != 0xB9000000)
```


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D112063/new/

https://reviews.llvm.org/D112063