[PATCH] D92695: [X86ISelLowering] don't emit frame pointers for eflags intrinsics.

[Craig Topper via Phabricator via llvm-commits]

craig.topper added inline comments.


================
Comment at: llvm/lib/Target/X86/X86ISelLowering.cpp:25975-25976
-      // sequence.
-      MachineFrameInfo &MFI = DAG.getMachineFunction().getFrameInfo();
-      MFI.setHasCopyImplyingStackAdjustment(true);
       // Don't do anything here, we will expand these intrinsics out later
----------------
pengfei wrote:
> How about address Craig and Reid's concerns by adding the check conditions like above?
emitPrologue calls setUsesRedZone. That would occur after this code runs. This is too early to call getUsesRedZone.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D92695/new/

https://reviews.llvm.org/D92695