[PATCH] D112443: [SelectionDAG] Optimize expansion for rotates/funnel shifts

Craig Topper via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Oct 26 12:10:23 PDT 2021


craig.topper added inline comments.


================
Comment at: llvm/lib/CodeGen/SelectionDAG/LegalizeIntegerTypes.cpp:4406
+  // Expand to a pair of funnel shifts.
+  EVT NewShAmtVT = TLI.getShiftAmountTy(HalfVT, DAG.getDataLayout(), false);
+  SDValue NewShAmt = DAG.getAnyExtOrTrunc(ShAmt, DL, NewShAmtVT);
----------------
Drop the `false`. I don't think it is needed.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D112443/new/

https://reviews.llvm.org/D112443



More information about the llvm-commits mailing list