[compiler-rt] c79d484 - [TSan] Ensure test uses tagged pointer

Julian Lettner via llvm-commits llvm-commits at lists.llvm.org
Tue Oct 26 11:53:10 PDT 2021


Author: Julian Lettner
Date: 2021-10-26T11:53:02-07:00
New Revision: c79d484ab1bf953089f3a21345f7d15ed611d533

URL: https://github.com/llvm/llvm-project/commit/c79d484ab1bf953089f3a21345f7d15ed611d533
DIFF: https://github.com/llvm/llvm-project/commit/c79d484ab1bf953089f3a21345f7d15ed611d533.diff

LOG: [TSan] Ensure test uses tagged pointer

This is a test-only failure. The test wrongly assumes that this gets us
a tagged pointer:
```
NSObject* num1 = @7;
assert(isTaggedPtr(num1));
```

However, on newer deployment targets that have “const data support” we
get a “normal” pointer to constant object.

Radar-Id: rdar://problem/83217293

Added: 
    

Modified: 
    compiler-rt/test/tsan/Darwin/objc-synchronize-cycle-tagged.mm

Removed: 
    


################################################################################
diff  --git a/compiler-rt/test/tsan/Darwin/objc-synchronize-cycle-tagged.mm b/compiler-rt/test/tsan/Darwin/objc-synchronize-cycle-tagged.mm
index c438984f1e5dd..23589365ee437 100644
--- a/compiler-rt/test/tsan/Darwin/objc-synchronize-cycle-tagged.mm
+++ b/compiler-rt/test/tsan/Darwin/objc-synchronize-cycle-tagged.mm
@@ -15,7 +15,7 @@ int main(int argc, char* argv[]) {
 
   @autoreleasepool {
     NSObject* obj = [NSObject new];
-    NSObject* num1 = @7;
+    NSObject* num1 = [NSNumber numberWithInt:7];
     NSObject* num2 = [NSNumber numberWithInt:arg];
 
     assert(!isTaggedPtr(obj));


        


More information about the llvm-commits mailing list