[PATCH] D111300: [VPlan] Keep induction recipes in header.

Ayal Zaks via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Oct 26 10:56:05 PDT 2021


Ayal accepted this revision.
Ayal added a comment.
This revision is now accepted and ready to land.

Minor last comment nit.



================
Comment at: llvm/lib/Transforms/Vectorize/LoopVectorize.cpp:9354
+          // Make sure induction recipes are all kept in the header block, to
+          // easily get all induction recipes directly from a VPlan.
+          auto *Header = Plan->getEntry()->getEntryBasicBlock();
----------------
That's clear, but suggest to explain what's unique about VPWidenIntOrFpInductionRecipe. E.g., something like:


```
// Make sure induction recipes are all kept in the header block.
// VPWidenIntOrFpInductionRecipe may be generated when reaching a
// Trunc of an induction Phi, where Trunc may not be in the header.
```


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D111300/new/

https://reviews.llvm.org/D111300



More information about the llvm-commits mailing list