[PATCH] D109944: [lld-macho] Associate compact unwind entries with function symbols

Tue Oct 26 09:31:17 PDT 2021

int3 added a subscriber: oontvoo.
int3 added a comment.

@oontvoo want to have a look at the changes to `compact-unwind-both-local-and-dylib-personality.s` before I land it?

================
Comment at: lld/test/MachO/compact-unwind-both-local-and-dylib-personality.s:42
 # BC-NEXT: address                    index name
-# BC-DAG:  0x[[#%x,GXX_PERSONALITY_HI:]] LOCAL
-# BC-DAG:  0x[[#%x,GXX_PERSONALITY_LO:]] LOCAL
-# BC-DAG:  0x[[#%x,PERSONALITY_1:]]  LOCAL
-# BC-DAG:  0x[[#%x,PERSONALITY_2:]]  LOCAL
+# C:       0x[[#%x,GXX_PERSONALITY_HI:]] LOCAL
+# BC:      0x[[#%x,GXX_PERSONALITY_LO:]] LOCAL
----------------
int3 wrote:
> I removed the `-DAG` part here because it seems we are actually relying on the local symbols matching in exactly that order
It seems that in the case of `b.out`, we don't emit this extra local binding. I haven't dug into why but I think it should be safe since that binding wasn't being used anyway

================
Comment at: lld/test/MachO/compact-unwind-both-local-and-dylib-personality.s:42-45
+# C:       0x[[#%x,GXX_PERSONALITY_HI:]] LOCAL
+# BC:      0x[[#%x,GXX_PERSONALITY_LO:]] LOCAL
+# BC:      0x[[#%x,PERSONALITY_1:]]      LOCAL
+# BC:      0x[[#%x,PERSONALITY_2:]]      LOCAL
----------------
I removed the `-DAG` part here because it seems we are actually relying on the local symbols matching in exactly that order

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D109944/new/

https://reviews.llvm.org/D109944