[PATCH] D112454: [SLP]Improve/fix reordering of the gathered graph nodes.

Alexey Bataev via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Oct 26 09:24:24 PDT 2021


ABataev added a comment.

In D112454#3087838 <https://reviews.llvm.org/D112454#3087838>, @RKSimon wrote:

> LGTM, although tbh I'm still not totally clear on the 'partial identity' path

The identity is 'partial' only in terms that some of the scalars are/may be replaced by undefs, so actually, it is a regular identity, where some indeces are undefs.



================
Comment at: llvm/lib/Transforms/Vectorize/SLPVectorizer.cpp:7459
 
-  bool doInitialization(Module &M) override {
-    return false;
-  }
+  bool doInitialization(Module &M) override { return false; }
 
----------------
RKSimon wrote:
> split off this NFC clang-format change
Did this accidentally, will restore the original code.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D112454/new/

https://reviews.llvm.org/D112454



More information about the llvm-commits mailing list