[PATCH] D108539: [X86][AVX] Attempt to fold a scaled index into a gather/scatter scale immediate (PR13310)

[Craig Topper via Phabricator via llvm-commits]

craig.topper added inline comments.


================
Comment at: llvm/test/CodeGen/X86/masked_gather_scatter.ll:774
 ; KNL_64-NEXT:    kxnorw %k0, %k0, %k1
-; KNL_64-NEXT:    vgatherqps (%rax,%zmm0), %ymm1 {%k1}
+; KNL_64-NEXT:    vxorps %xmm1, %xmm1, %xmm1
+; KNL_64-NEXT:    vgatherqps (%rax,%zmm0,4), %ymm1 {%k1}
----------------
pengfei wrote:
> RKSimon wrote:
> > pengfei wrote:
> > > Why do we need an extra xor now?
> > D112505 - for dependency breaking I guess :) 
> Interesting :)
I guess this is because we were calling getAVX2Gather which adds dependency breaking?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D108539/new/

https://reviews.llvm.org/D108539