[PATCH] D111703: [ARM] __cxa_end_cleanup should be called instead of _UnwindResume.

Logan Chien via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Oct 26 08:12:22 PDT 2021


logan requested changes to this revision.
logan added inline comments.
This revision now requires changes to proceed.


================
Comment at: llvm/lib/CodeGen/DwarfEHPrepare.cpp:225
   // Find the rewind function if we didn't already.
   if (!RewindFunction) {
+    FunctionType *FTy;
----------------
Thinking this further, I think we can no longer cache RewindFunction as a data member, since there may be functions with different personality functions in the same module.  If we cache it in this way, we may get errors when some functions expect `_Unwind_Resume` and the others expect `__cxa_end_cleanup` (in the same module).


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D111703/new/

https://reviews.llvm.org/D111703



More information about the llvm-commits mailing list