[PATCH] D112286: Generalize DWARF tests that expect DW_FORM_strp

Jake Egan via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Oct 26 06:17:02 PDT 2021


Jake-Egan added inline comments.


================
Comment at: llvm/test/DebugInfo/Generic/containing-type-extension.ll:8
 ; CHECK: DW_AT_containing_type [DW_FORM_ref4]
-; CHECK: DW_AT_name [DW_FORM_strp] {{.*}}= "vtable")
+; CHECK: DW_AT_name {{.*}}= "vtable")
 
----------------
dblaikie wrote:
> I'd drop the "= " here (& elsewhere in the patch), like it's done elsewhere
I was going to do that in a separate patch for the whitespace. I think it's more related to the whitespace issue do you think? The patch would remove both = and spaces.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D112286/new/

https://reviews.llvm.org/D112286



More information about the llvm-commits mailing list