[PATCH] D112499: [OpenMP] Initial parsing/sema for the 'omp loop' construct

[Alexey Bataev via Phabricator via llvm-commits]

ABataev added inline comments.


================
Comment at: clang/include/clang/AST/StmtOpenMP.h:5490
+///
+class OMPGenericLoopDirective : public OMPLoopDirective {
+  friend class ASTStmtReader;
----------------
`final`


================
Comment at: clang/lib/Basic/OpenMPKinds.cpp:683
+  case OMPD_loop:
+    CaptureRegions.push_back(OMPD_loop);
+    break;
----------------
Why it cannot be just `OMPD_unknown` here just like for `omp for` directive? Should it be outlined as a function?


================
Comment at: clang/lib/CodeGen/CGStmt.cpp:397
+  case Stmt::OMPGenericLoopDirectiveClass:
+    llvm_unreachable("codegen for loop directive not yet implemented");
   }
----------------
Better just to emit it as an inlined directive.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D112499/new/

https://reviews.llvm.org/D112499