[PATCH] D112467: [SLP]Do not reorder reduction nodes.

Simon Pilgrim via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Oct 26 04:37:35 PDT 2021


RKSimon added inline comments.


================
Comment at: llvm/lib/Transforms/Vectorize/SLPVectorizer.cpp:2823
 
-void BoUpSLP::reorderBottomToTop() {
+void BoUpSLP::reorderBottomToTop(bool FreeReorder) {
   SetVector<TreeEntry *> OrderedEntries;
----------------
ABataev wrote:
> RKSimon wrote:
> > Is FreeOrder the right name? Its suggests a cost but AFAICT this really just says that the final order is irrelevant/unecessary?
> Any better suggestions? The idea that if this is set to true, we do no need to reorder the root node of the tree/graph.
IgnoreReorder? SkipReorder?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D112467/new/

https://reviews.llvm.org/D112467



More information about the llvm-commits mailing list