[PATCH] D112525: [LNT] Add more information to error messages

Dmitry Vassiliev via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Oct 26 04:18:46 PDT 2021


slydiman added inline comments.


================
Comment at: lnt/server/ui/views.py:814-815
         except ValueError:
-            return abort(400)
+            return abort(400, "Parameter {} was malformed. {} must be int.int.int" \
+                              .format(name, value))
 
----------------
kpdev42 wrote:
> thopre wrote:
> > Is it still the case, I remember a  patch that wanted to allow arbitrary strings
> AFAIK, yes, URL is expected to contain something like ?plot.0=1.2.3 . If you can point to a patch, which allows arbitrary string, it would be useful and I'll change this part
It is just a copy of the line 1716. The same is in the line 855.


Repository:
  rLNT LNT

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D112525/new/

https://reviews.llvm.org/D112525



More information about the llvm-commits mailing list