[PATCH] D112496: [RISCV] Replace most uses of RISCVSubtarget::hasStdExtV. NFCI

[Fraser Cormack via Phabricator via llvm-commits]

frasercrmck added a comment.

Thanks, I think this is the sensible thing to do.



================
Comment at: llvm/lib/Target/RISCV/RISCV.td:153
+def HasVInstructions    : Predicate<"Subtarget->hasVInstructions()">;
+def HasVInstructionsF32 : Predicate<"Subtarget->hasVInstructionsF32()">;
+
----------------
I was wondering if some uses of this are better expressed as `HasVInstructionsAnyF` or something, such as when defining the instructions themselves. It's not a big deal if everyone knows that having Zfh/D implies having F but I just think that there may be two subtly-different meanings of this predicate which could make maintenance more difficult.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D112496/new/

https://reviews.llvm.org/D112496