[PATCH] D111289: [LNT] Refactored the Graph page to use the library plotly instead of jQuery.flot
Pavel Kosov via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Oct 26 02:28:38 PDT 2021
kpdev42 added a comment.
In D111289#3085371 <https://reviews.llvm.org/D111289#3085371>, @cmatthews wrote:
> As a start, split the non-patch related changes out. Specifically, at least split the changes in: test_matrix_page.py, test_api.py, the renames, the error message updates in views.py, the refactoring in api.py.
>
> We need test coverage in all this code being added as well.
>
> Move some of this out into a series of refactorings, before the main final change, that will help make it simpler to reason about the changes.
Thanks for suggestions. I will try to split this patch
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D111289/new/
https://reviews.llvm.org/D111289
More information about the llvm-commits
mailing list