[PATCH] D82549: [AIX][XCOFF] parsing xcoff object file auxiliary header

Esme Yi via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Oct 26 02:05:51 PDT 2021


Esme accepted this revision.
Esme added a comment.
This revision is now accepted and ready to land.

LGTM with small nits.



================
Comment at: llvm/tools/llvm-readobj/XCOFFDumper.cpp:597
+    return;
+  }
+  uint16_t AuxSize = Obj.getOptionalHeaderSize();
----------------
Remove braces since it's a single-line if.


================
Comment at: llvm/tools/llvm-readobj/XCOFFDumper.cpp:683
+    return;
+  }
+  uint16_t AuxSize = Obj.getOptionalHeaderSize();
----------------
Ditto.


================
Comment at: llvm/tools/llvm-readobj/llvm-readobj.cpp:354
+    Dumper->printAuxiliaryHeader();
+  }
+
----------------
Ditto.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D82549/new/

https://reviews.llvm.org/D82549



More information about the llvm-commits mailing list