[PATCH] D111125: [NFC][LoopVectorize] Remove setBestPlan in favour of getBestPlanFor

[Florian Hahn via Phabricator via llvm-commits]

fhahn added inline comments.


================
Comment at: llvm/lib/Transforms/Vectorize/LoopVectorize.cpp:8192
 
-void LoopVectorizationPlanner::setBestPlan(ElementCount VF, unsigned UF) {
-  LLVM_DEBUG(dbgs() << "Setting best plan to VF=" << VF << ", UF=" << UF
-                    << '\n');
-  BestVF = VF;
-  BestUF = UF;
+VPlan *LoopVectorizationPlanner::getBestPlanFor(ElementCount VF) const {
+  assert(count_if(VPlans,
----------------
can we instead return a reference?


================
Comment at: llvm/lib/Transforms/Vectorize/LoopVectorize.cpp:8209
                                            DominatorTree *DT) {
+  LLVM_DEBUG(dbgs() << "Setting best plan to VF=" << BestVF << ", UF=" << BestUF
+                    << '\n');
----------------
This seems a bit inaccurate now. Maybe it would be better to say `Executing best plan with VF, UF` or something like that?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D111125/new/

https://reviews.llvm.org/D111125