[PATCH] D112402: [SCEV][NFC] Verify intergity of SCEVUsers
Max Kazantsev via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Oct 25 22:40:05 PDT 2021
mkazantsev added inline comments.
================
Comment at: llvm/lib/Analysis/ScalarEvolution.cpp:12905
+ SmallPtrSet<const SCEV *, 4> Ops;
+ if (const auto *NS = dyn_cast<SCEVNAryExpr>(&S))
+ Ops.insert(NS->op_begin(), NS->op_end());
----------------
mkazantsev wrote:
> reames wrote:
> > This code exists in at least one other place (getDefiningScopeBound). I'm fine with this landing as is, but we should probably start thinking about how to abstract user and operand walks.
> Will see if I can follow-up with factoring out this common part.
https://reviews.llvm.org/D112516
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D112402/new/
https://reviews.llvm.org/D112402
More information about the llvm-commits
mailing list