[PATCH] D112445: [fir] Add fir.array_access op

Mehdi AMINI via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Oct 25 20:32:57 PDT 2021


mehdi_amini requested changes to this revision.
mehdi_amini added a comment.
This revision now requires changes to proceed.

I am a bit concerned by the semantics here:  `fir.array_load` is supposed to provide an immutable SSA value that correspond to an array. The `fir.array_access` presented here seems to get some sort of (mutable?) memory address "after the fact".
This really breaks the SSA immutable value-type model associated with `fir.array`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D112445/new/

https://reviews.llvm.org/D112445



More information about the llvm-commits mailing list