[PATCH] D112485: [lld-macho][nfc] Test that we don't emit undef symbol errors for dead code

[Douglas Yung via Phabricator via llvm-commits]

dyung added a comment.

In D112485#3086138 <https://reviews.llvm.org/D112485#3086138>, @oontvoo wrote:

> In D112485#3086130 <https://reviews.llvm.org/D112485#3086130>, @dyung wrote:
>
>> In D112485#3086100 <https://reviews.llvm.org/D112485#3086100>, @oontvoo wrote:
>>
>>> In D112485#3086095 <https://reviews.llvm.org/D112485#3086095>, @thakis wrote:
>>>
>>>> This breaks tests: http://45.33.8.238/linux/59085/step_11.txt
>>>>
>>>> PTAL :)
>>>
>>> Seemed to be fixed by https://github.com/llvm/llvm-project/commit/d3ddd569eb78ae4e042502775704bd27c0c0a543
>>
>> The PS4 linux build bot is still failing after that fix:
>> https://lab.llvm.org/buildbot/#/builders/139/builds/12148
>>
>>   Command Output (stderr):
>>   --
>>   split-file: error: /home/buildbot/buildbot-root/llvm-clang-x86_64-sie-ubuntu-fast/llvm-project/lld/test/MachO/treat-undef-sym.s: No such file or directory
>>   --
>
> Oh, I think int3 should have `rm %t` and not `%s`!
> should be fixed with https://github.com/llvm/llvm-project/commit/46ef187dccd3be85d0490cf3e5dc73607a4a2ef2 now

Still failing I'm afraid :(

https://lab.llvm.org/buildbot/#/builders/139/builds/12149

  Command Output (stderr):
  --
  /home/buildbot/buildbot-root/llvm-clang-x86_64-sie-ubuntu-fast/llvm-project/lld/test/MachO/treat-undef-sym.s:40:10: error: ERROR: expected string not found in input
  # ERROR: error: undefined symbol: _bar
           ^
  <stdin>:1:1: note: scanning from here
  ld64.lld: error: cannot open /home/buildbot/buildbot-root/llvm-clang-x86_64-sie-ubuntu-fast/build/tools/lld/test/MachO/Output/treat-undef-sym.s.tmp/dead.o: No such file or directory
  ^
  <stdin>:1:11: note: possible intended match here
  ld64.lld: error: cannot open /home/buildbot/buildbot-root/llvm-clang-x86_64-sie-ubuntu-fast/build/tools/lld/test/MachO/Output/treat-undef-sym.s.tmp/dead.o: No such file or directory
            ^
  Input file: <stdin>
  Check file: /home/buildbot/buildbot-root/llvm-clang-x86_64-sie-ubuntu-fast/llvm-project/lld/test/MachO/treat-undef-sym.s
  -dump-input=help explains the following input dump.
  Input was:
  <<<<<<
              1: ld64.lld: error: cannot open /home/buildbot/buildbot-root/llvm-clang-x86_64-sie-ubuntu-fast/build/tools/lld/test/MachO/Output/treat-undef-sym.s.tmp/dead.o: No such file or directory 
  check:40'0     X~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ error: no match found
  check:40'1               ?                                                                                                                                                                            possible intended match
  >>>>>>
  --


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D112485/new/

https://reviews.llvm.org/D112485