[PATCH] D112500: [lld-macho] Put GOT into `__DATA` segment where appropriate
Vy Nguyen via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Oct 25 17:28:30 PDT 2021
oontvoo added inline comments.
================
Comment at: lld/MachO/SyntheticSections.cpp:262
GotSection::GotSection()
- : NonLazyPointerSectionBase(segment_names::dataConst, section_names::got) {
+ : NonLazyPointerSectionBase(segment_names::data, section_names::got) {
flags = S_NON_LAZY_SYMBOL_POINTERS;
----------------
it's still not quite correct to unconditionally put it in non-const, though.
(there's the `-data_const` flag for one )
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D112500/new/
https://reviews.llvm.org/D112500
More information about the llvm-commits
mailing list