[PATCH] D107872: [SimplifyLibCalls] propagate tail/musttail/notail flags on CallInsts

Nick Desaulniers via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Oct 25 15:55:32 PDT 2021


nickdesaulniers added inline comments.


================
Comment at: llvm/lib/Transforms/InstCombine/InstCombineCalls.cpp:2427-2429
+  // Must tail has invariants like trying not to refer to the callers stack
+  // frame via allocas. At the risk of LibCallSimplifier::optimizeCall()
+  // inserting such allocas, just skip libcall optimizing must tail calls.
----------------
There's probably a better way to express/word this. @efriedma please let me know what to replace here.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D107872/new/

https://reviews.llvm.org/D107872



More information about the llvm-commits mailing list