[PATCH] D90868: [IR] Define @llvm.ptrauth intrinsics.

[Ahmed Bougacha via Phabricator via llvm-commits]

ab marked 2 inline comments as done.
ab added inline comments.


================
Comment at: llvm/docs/PointerAuth.md:22
+
+## Concepts
+
----------------
pbarrio wrote:
> Maybe I'm jumping a bit ahead of myself here.
> 
> I was reading the fully-patched toolchain (e.g. here: https://github.com/pcc/llvm-project/tree/apple-pac3) and I noticed most of these concepts are explained in clang/docs/PointerAuthentication.rst in more detail. Should we have them only in one place and reference the other document? I really like how the Clang document explains the high-level workings of PAuth, and this document seems more focused on the internal implementation in LLVM. Ofc you may have other plans for the two-document split :)
> 
> For example, we could just point out the correspondence with the other document in the next section:
> 
> 
> ```
> ## LLVM IR Representation
> 
> ### Intrinsics
> 
> The intrinsics implement the three fundamental operations in PAuth (sign, auth, and strip), as well as a bundle (resign), a generic data signing and an operation to help generate different types of discriminators (blend). For more information on PAuth operations, check out <link to Clang document Section "Basic concepts">.  Also, <link to Clang document Section "Discriminators"> explains discriminators in detail.
> ```
> Or something like that.
> 
> I would expect anyone interested in this document to have read the other document first, or at least similar Arm documents, so they should already be familiar with how PAuth works.
Yep, the clang page comes after, but I added a link here in the later commit that introduces it.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D90868/new/

https://reviews.llvm.org/D90868