[PATCH] D112488: AMDGPU: Assume all amdhsa kernarg passed implicit arguments by default

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Oct 25 14:23:46 PDT 2021


arsenm added inline comments.


================
Comment at: llvm/lib/Target/AMDGPU/AMDGPUSubtarget.cpp:659
+
+  // Assume all implicit inputs are used by default
+  return AMDGPU::getIntegerAttribute(F, "amdgpu-implicitarg-num-bytes", 56);
----------------
rampitec wrote:
> It is not immediately obvious we have a HSA kernel at this point.
This is only meaningfully called with a kernel


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D112488/new/

https://reviews.llvm.org/D112488



More information about the llvm-commits mailing list