[PATCH] D112472: [Scalarizer] Do not insert instructions between PHI nodes.
Daniele Vettorel via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Oct 25 12:33:05 PDT 2021
vettoreldaniele added a comment.
In D112472#3085376 <https://reviews.llvm.org/D112472#3085376>, @lebedev.ri wrote:
> I think it would be more foolproof to do that in the constructor of the class.
I feel like it would be confusing to have some logic around the insertion point in the constructor when the majority of the logic around that is in `scatter()`. I'd prefer to have the constructor require the insertion point to be valid rather than fixing it if passed an invalid one.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D112472/new/
https://reviews.llvm.org/D112472
More information about the llvm-commits
mailing list