[PATCH] D111703: [ARM] __cxa_end_cleanup should be called instead of _UnwindResume.

Martin Storsjö via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Oct 25 11:58:05 PDT 2021


mstorsjo added inline comments.


================
Comment at: llvm/include/llvm/ADT/Triple.h:735
+            getEnvironment() == Triple::MuslEABIHF || isAndroid()) &&
+           !isOSDarwin() && !isOSWindows();
+  }
----------------
MaskRay wrote:
> Can Darwin or Windows use EHABI related environment? If not, remove `!isOSDarwin() && !isOSWindows()`.
> If possible, check isOSBinFormatELF() instead
At least windows can’t, afaik (I haven’t heard about anybody setting that up, and neither llvm nor libunwind support it).


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D111703/new/

https://reviews.llvm.org/D111703



More information about the llvm-commits mailing list