[PATCH] D111930: Add support for Bazel builds on Windows with `clang-cl`.

Geoffrey Martin-Noble via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Oct 25 11:38:59 PDT 2021


GMNGeoffrey accepted this revision.
GMNGeoffrey added inline comments.
This revision is now accepted and ready to land.


================
Comment at: utils/bazel/llvm-project-overlay/llvm/unittests/BUILD.bazel:115
     name = "codegen_tests",
-    size = "small",
+    size = "medium",
     srcs = glob(
----------------
chandlerc wrote:
> GMNGeoffrey wrote:
> > Hmmm unfortunate that these have to increase specifically for windows. Do windows tests take longer overall? We could change the actual timeouts corresponding to the timeout names instead.
> Tests aren't generally slower, just certain *kinds* of tests. =/
> 
> Specifically, GoogleTest's "death tests" are both much slower and have much higher variability on Windows AFAICT.
> 
> I can defer these if you want and try to get statistics on how important they are, and where. I just added these when during testing I got some timeouts.
Bleh. Seems like no good solution. This is fine.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D111930/new/

https://reviews.llvm.org/D111930



More information about the llvm-commits mailing list