[PATCH] D112443: [SelectionDAG] Optimize expansion for rotates/funnel shifts

[Craig Topper via Phabricator via llvm-commits]

craig.topper added a comment.

Code change LGTM. X86 and RISCV tests LGTM.



================
Comment at: llvm/lib/CodeGen/SelectionDAG/LegalizeIntegerTypes.cpp:4418
+
+  // If the shift amount is at least half the bitwidth, swap the inputs
+  unsigned HalfVTBits = HalfVT.getScalarSizeInBits();
----------------
Add a full stop at the end of this comment to match the other comments in this function.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D112443/new/

https://reviews.llvm.org/D112443