[PATCH] D107934: [LowerTypeTests] Emit cfi_jt aliases regardless of function export

[Nick Desaulniers via Phabricator via llvm-commits]

nickdesaulniers added inline comments.


================
Comment at: llvm/test/ThinLTO/X86/cfi_jt_aliases.ll:1
+; RUN: opt -thinlto-bc -thinlto-split-lto-unit %s -o %t.bc
+; RUN: llvm-lto2 run -o %t.o %t.bc \
----------------
tejohnson wrote:
> nickdesaulniers wrote:
> > tejohnson wrote:
> > > I can't quite tell - is this checking both the exported and non-exported cases? Comments would be helpful, and maybe explicitly checking llvm.used contents in the IR for the non-exported case.
> > The exported case should be full LTO, while the non-exported case should be thin LTO.  I've copied this test to llvm/test/LTO/... as well, and added the test for `@llvm.used` there. PTAL.
> > The exported case should be full LTO, while the non-exported case should be thin LTO. I've copied this test to llvm/test/LTO/... as well, and added the test for @llvm.used there. PTAL.
> 
> Did you state this backwards, since the full LTO case is checking for the llvm.used which must mean it is non-exported? Or am I misinterpreting?
*egg on face*

Yes; you're right.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D107934/new/

https://reviews.llvm.org/D107934