[PATCH] D112250: Support: Reduce stats in fs::copy_file on Darwin

[Jonas Devlieghere via Phabricator via llvm-commits]

JDevlieghere accepted this revision.
JDevlieghere added a comment.
This revision is now accepted and ready to land.

LGTM

In D112250#3079555 <https://reviews.llvm.org/D112250#3079555>, @dexonsmith wrote:

> Unit test is failing on Windows:
>
>   [ RUN      ] FileSystemTest.CopyFileW
>   C:\ws\w4\llvm-project\premerge-checks\llvm\unittests\Support\Path.cpp(2335): error: fs::create_link(path::filename(Sources[2]), Symlink): did not return errc::success.
>   error number: 2
>   error message: no such file or directory
>    
>   [  FAILED  ] FileSystemTest.CopyFileW (874 ms)
>
> Given we don't support creating symlinks on Windows and the behaviour has only changed on Darwin, I'm not sure this is important to debug. Thoughts on making this test `#ifndef _WIN32`?

Sounds reasonable to me.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D112250/new/

https://reviews.llvm.org/D112250