[PATCH] D112435: [GlobalISel] Add G_BFI (bitfield insertion opcode)
Matt Arsenault via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Oct 25 10:29:12 PDT 2021
arsenm added inline comments.
================
Comment at: llvm/lib/CodeGen/MachineVerifier.cpp:1616
+ LLT DstTy = MRI->getType(MI->getOperand(0).getReg());
+ if (DstTy.isVector()) {
+ report("Bitfield insertion is not supported on vectors", MI);
----------------
arsenm wrote:
> paquette wrote:
> > Maybe add a FIXME or TODO here noting that it may make sense to extend this to vectors in the future? (I can't think of any use-cases, but maybe it makes sense on some target...)
> Supporting on vectors is good for consistency and also can help with combine ordering problems
I don't think this should disallow vectors. Having the legalizer scalarize is trivial
I think it's a better question if the second/third operands can be vectors or not
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D112435/new/
https://reviews.llvm.org/D112435
More information about the llvm-commits
mailing list