[PATCH] D112463: [LangRef][NFC] Remove incorrect vector alignment rules

Mon Oct 25 09:29:49 PDT 2021

frasercrmck added a comment.

In D112463#3084766 <https://reviews.llvm.org/D112463#3084766>, @aeubanks wrote:

> I wouldn't call this "NFC" if it's updating the LangRef

I can see that, yeah. I'm happy to defer to your judgement on that. The absence of NFC doesn't hurt as much as a badly-placed NFC.

================
Comment at: llvm/unittests/IR/DataLayoutTest.cpp:102
+  // The alignment for a vector type larger than any specified vector type uses
+  // the natual alignment as a fallback. This is contrary to old LangRef
+  // documentation which claimed it would use the largest vector type smaller
----------------
aeubanks wrote:
> aeubanks wrote:
> > natural
> I would just delete everything after this, it's not useful to anybody in the future.
Yeah, good point; agreed.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D112463/new/

https://reviews.llvm.org/D112463