[PATCH] D111836: [indvars] Use fact loop must exit to canonicalize to unsigned conditions

Philip Reames via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Oct 25 09:29:14 PDT 2021


reames added a comment.

In D111836#3084709 <https://reviews.llvm.org/D111836#3084709>, @reames wrote:

> In D111836#3084204 <https://reviews.llvm.org/D111836#3084204>, @spatel wrote:
>
>> This patch causes an infinite loop in a compiled program:
>> https://llvm.org/PR52276
>
> Confirmed.  The problem is a missing one-use check.  The reasoning on the exit condition is valid, but the application of that to a use outside the loop is not.  I'm going to revert and then reapply with the fix to make the history a bit easier to follow.

Should be fixed in f82cf618 <https://reviews.llvm.org/rGf82cf6187fbe9584ba0a8d9bf4d703498df249e6>.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D111836/new/

https://reviews.llvm.org/D111836



More information about the llvm-commits mailing list