[PATCH] D112454: [SLP]Improve/fix reordering of the gathered graph nodes.

Simon Pilgrim via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Oct 25 08:11:51 PDT 2021


RKSimon added inline comments.


================
Comment at: llvm/lib/Transforms/Vectorize/SLPVectorizer.cpp:2700
+        return None;
+      IsIdentity |= Lane == I;
+      if (CurrentOrder[Lane] != E)
----------------
ABataev wrote:
> RKSimon wrote:
> > Don't all the lanes need to match for this to be Identity?
> Not necessarily, partial matching is good too.
Maybe add a description comment then? I took this to mean we have a identity permute mask.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D112454/new/

https://reviews.llvm.org/D112454



More information about the llvm-commits mailing list