[PATCH] D112435: [GlobalISel] Add G_BFI (bitfield insertion opcode)

Konstantin Schwarz via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Oct 25 07:52:38 PDT 2021


kschwarz added a comment.

Thanks for the quick review @foad!



================
Comment at: llvm/lib/CodeGen/MachineVerifier.cpp:1617
+    if (DstTy.isVector()) {
+      report("Bitfield insertion is not supported on vectors", MI);
+      break;
----------------
foad wrote:
> Any reason why it's not supported?
Not really. I wanted to focus on scalars first, and basically took this from the bitfield extracts above.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D112435/new/

https://reviews.llvm.org/D112435



More information about the llvm-commits mailing list