[PATCH] D111164: Regenerate LC_CODE_SIGNATURE during llvm-objcopy operations

[Nuri Amari via Phabricator via llvm-commits]

nuriamari added inline comments.


================
Comment at: llvm/test/tools/llvm-objcopy/MachO/code_signature_lc_update.test:69
+# CHECK-REMOVE-NEXT: dataoff 16544
+# CHECK-REMOVE-NEXT: datasize 320
+
----------------
thevinster wrote:
> Just wondering here, from inspection, shouldn't this be 280? To match the lines indicating `CHECK-ORIGINAL`?
Not necessarily since I don't think the increase to `320` is entirely a result of the new RPATH command. The datasize can often change the first time llvm-objcopy is run on a binary, even without any changes. You can see an example in `code_signature_lc.test` file, the datasize also inflates. I think this is just a consequence of llvm-objcopy slightly changing binaries produced by other tools. Once llvm-objcopy is run on the binary once, no changes are observed on a further runs.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D111164/new/

https://reviews.llvm.org/D111164