[PATCH] D112324: [DebugInfo][InstrRef] Recover some performance from tracking stack-slot sublocations

[Orlando Cazalet-Hyams via Phabricator via llvm-commits]

Orlando accepted this revision.
Orlando added a comment.
This revision is now accepted and ready to land.

LGTM



================
Comment at: llvm/unittests/CodeGen/InstrRefLDVTest.cpp:1101
+  SpillLocationNo SpillNo = MTracker->getOrTrackSpillLoc(SL);
+  ASSERT_EQ(MTracker->getNumLocs(), 10u); // tracks all possible stack locs
+
----------------
What are the 10 locs? (plus nit: comment needs capital and full stop)


================
Comment at: llvm/unittests/CodeGen/InstrRefLDVTest.cpp:1149
+  // to reduce IDF calculation does the right thing.
+  // AH should not be def'd: it don't alias AL or HAX.
+  //
----------------
nit: `don't` -> `doesn't`


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D112324/new/

https://reviews.llvm.org/D112324