[PATCH] D112411: [LNT] Updated cPerf to read the section Attributes (support Simpleperf)

Pavel Kosov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Oct 25 05:18:48 PDT 2021


kpdev42 marked an inline comment as done.
kpdev42 added inline comments.


================
Comment at: lnt/testing/profile/cPerf.cpp:346
+      // Symbols with odd addresses signify functions in THUMB mode.
+      uint64_t Start = strtoull(One.c_str(), &EndPtr, 16) & ~(uint64_t)1;
       if (EndPtr == One.c_str())
----------------
thopre wrote:
> Are we sure this is safe for all architectures? Is there no architecture where functions can be unaligned?
Remove this for now (maybe will add this functionality later)


Repository:
  rLNT LNT

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D112411/new/

https://reviews.llvm.org/D112411



More information about the llvm-commits mailing list