[PATCH] D112435: [GlobalISel] Add G_BFI (bitfield insertion opcode)

[Jay Foad via Phabricator via llvm-commits]

foad added inline comments.


================
Comment at: llvm/include/llvm/Target/GenericOpcodes.td:1422
+
+def G_BFI : GenericInstruction {
+  let OutOperandList = (outs type0:$dst);
----------------
Can you add a comment like for sbfx and ubfx, and explain the limits on pos and witdth?


================
Comment at: llvm/lib/CodeGen/MachineVerifier.cpp:1617
+    if (DstTy.isVector()) {
+      report("Bitfield insertion is not supported on vectors", MI);
+      break;
----------------
Any reason why it's not supported?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D112435/new/

https://reviews.llvm.org/D112435