[PATCH] D112300: [InstCombine] Don't split up Loads and free Exts

[Andre Vieira via Phabricator via llvm-commits]

avieira added a comment.

@lebedev.ri what do you suggest I do? I am not entirely sure I agree that sinking instructions like this is canonicalization, but that aside, separating these Loads and Exts is making codegen worse for targets that support widening loads. Targets that don't would probably be better off with the sinking transformation. This is why I'd like to use TTI here.

I guess I could go back to my previous approach of doing this later in TypePromotion, where TTI can be used, but I do believe it would be better to prevent this transformation rather than trying to undo it.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D112300/new/

https://reviews.llvm.org/D112300