[PATCH] D111288: [fir] Add data flow optimization pass

[Valentin Clement via Phabricator via llvm-commits]

clementval added inline comments.


================
Comment at: flang/test/Fir/memref-data-flow.fir:73
+// CHECK-NOT:     fir.store %{{.*}} to %{{.*}} : !fir.ref<i32>
+// CHECK-NOT:     %{{.*}} = fir.load %{{.*}} : !fir.ref<i32>
+// CHECK:         %{{.*}} = fir.convert %{{.*}} : (i32) -> i64
----------------
mehdi_amini wrote:
> This check-not is also followed by some identical checks, again the whole logic behind these checks is beyond me right now.
> 
We check that the fir.store/fir.load pair has been removed here (between the fir.convert ops). The next checks make sure the loads have been preserved later. I added a comment to make it clearer. 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D111288/new/

https://reviews.llvm.org/D111288