[PATCH] D112411: [LNT] Updated cPerf to read the section Attributes (support Simpleperf)

[Thomas Preud'homme via Phabricator via llvm-commits]

thopre added inline comments.


================
Comment at: lnt/testing/profile/cPerf.cpp:346
+      // Symbols with odd addresses signify functions in THUMB mode.
+      uint64_t Start = strtoull(One.c_str(), &EndPtr, 16) & ~(uint64_t)1;
       if (EndPtr == One.c_str())
----------------
Are we sure this is safe for all architectures? Is there no architecture where functions can be unaligned?


================
Comment at: lnt/testing/profile/cPerf.cpp:394
     }
-    return output.size();
+    return (int)output.size();
   }
----------------
Why is that needed? Is it just to fix a warning?


Repository:
  rLNT LNT

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D112411/new/

https://reviews.llvm.org/D112411