[PATCH] D111299: [VPlan] Do not create dummy entry block (NFC).

Ayal Zaks via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Oct 25 00:56:07 PDT 2021


Ayal accepted this revision.
Ayal added a comment.
This revision is now accepted and ready to land.

This is indeed better, thanks!
(Original version tried to simplify the loop by peeling setEntry(), but this does look better overall.)
Adding a minor nit.



================
Comment at: llvm/lib/Transforms/Vectorize/LoopVectorize.cpp:9351
   RecipeBuilder.fixHeaderPhis();
 
   // ---------------------------------------------------------------------------
----------------
Worth asserting that Plan Entry is set after the loop?
(Original version did this by calling getSingleSuccessor()).
(Perhaps also assert that this entry is not empty(?)).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D111299/new/

https://reviews.llvm.org/D111299



More information about the llvm-commits mailing list