[PATCH] D112206: [CSKY] First patch to construct codegen infra and generate first add instruction

Zixuan Wu via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Oct 24 19:46:46 PDT 2021


zixuan-wu marked 2 inline comments as done.
zixuan-wu added inline comments.


================
Comment at: llvm/lib/Target/CSKY/MCTargetDesc/CSKYBaseInfo.h:26
+// instruction info tracks. All definitions must match CSKYInstrFormats.td.
+namespace CSKYII {
+
----------------
rengolin wrote:
> What's the relation of this with `CSKYInstrInfo`?
> 
> How do other targets share that kind of stuff?
Sorry to can't understand what you mean. I think this comments are similar meaning as RISCVBaseInfo.h has.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D112206/new/

https://reviews.llvm.org/D112206



More information about the llvm-commits mailing list