[PATCH] D111317: [DebugInfo][InstrRef] Track instructions that write-to-stack after having a spill fused into them

Jeremy Morse via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Oct 24 14:40:37 PDT 2021


jmorse updated this revision to Diff 381803.
jmorse added a comment.

... and while I'm here, we should substitute instruction numbers when loads are folded into an instruction. See the added test memory-operand-load-folding.mir where the CVTTSS2SIrr (convert single precision number to signed int?) has a load folded into it. The instruction number should be preserved (with a substitution) for the sake of the value the instruction defines.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D111317/new/

https://reviews.llvm.org/D111317

Files:
  llvm/include/llvm/CodeGen/MachineFunction.h
  llvm/lib/CodeGen/InlineSpiller.cpp
  llvm/lib/CodeGen/LiveDebugValues/InstrRefBasedImpl.cpp
  llvm/lib/CodeGen/LiveDebugValues/InstrRefBasedImpl.h
  llvm/lib/CodeGen/MachineFunction.cpp
  llvm/test/DebugInfo/MIR/InstrRef/memory-operand-folding-tieddef.mir
  llvm/test/DebugInfo/MIR/InstrRef/memory-operand-folding.mir
  llvm/test/DebugInfo/MIR/InstrRef/memory-operand-load-folding.mir
  llvm/test/DebugInfo/MIR/InstrRef/memory-operand-tracking.mir

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D111317.381803.patch
Type: text/x-patch
Size: 37226 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20211024/2e10c11f/attachment-0001.bin>


More information about the llvm-commits mailing list