[PATCH] D110865: X86InstrInfo: Optimize more combinations of SUB+CMP

[Simon Pilgrim via Phabricator via llvm-commits]

RKSimon added inline comments.


================
Comment at: llvm/lib/Target/X86/X86InstrInfo.h:637
+  /// This function can be extended later on.
+  /// SrcReg, SrcRegs: register operands for FlagI.
+  /// ImmValue: immediate for FlagI if it takes an immediate.
----------------
SrcRegs -> SrcReg2 ?


================
Comment at: llvm/lib/Target/X86/X86InstrInfo.h:638
+  /// SrcReg, SrcRegs: register operands for FlagI.
+  /// ImmValue: immediate for FlagI if it takes an immediate.
+  bool isRedundantFlagInstr(const MachineInstr &FlagI, Register SrcReg,
----------------
Please describe IsSwapped as well


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D110865/new/

https://reviews.llvm.org/D110865