[PATCH] D107148: [InstCombine] Fold two-value clamp patterns

Sanjay Patel via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Oct 22 11:49:08 PDT 2021


spatel added a comment.

In D107148#3080892 <https://reviews.llvm.org/D107148#3080892>, @RKSimon wrote:

> @spatel Any thoughts?

Not with the direction - as noted earlier, we're already trying this with the intrinsics, so we doing it with cmp+select just makes things consistent. There are a few implementation/test questions:

1. What logic diffs are there between this and 025bb5290379 <https://reviews.llvm.org/rG025bb52903792de3dd29667d42c97fdf13a00f2b> ?
2. Add/adjust tests based on those diffs.
3. Use m_APInt so we get splat vectors.

@qiucf - will you continue this patch soon?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D107148/new/

https://reviews.llvm.org/D107148



More information about the llvm-commits mailing list